Skip to content

Allow setting hashmap toml values in ./configure #108644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2023
Merged

Allow setting hashmap toml values in ./configure #108644

merged 1 commit into from
Mar 3, 2023

Conversation

KittyBorgX
Copy link
Member

Fixes #108621

@rustbot
Copy link
Collaborator

rustbot commented Mar 2, 2023

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 2, 2023
@albertlarsan68
Copy link
Member

This doesn't do the right thing, here is a quick replacement you can inspire from:

"{" + ", ".join(map(lambda a: "{} = {}".format(to_toml(a[0]), to_toml(a[1])), value.items())) + "}"

@KittyBorgX
Copy link
Member Author

This doesn't do the right thing, here is a quick replacement you can inspire from:

"{" + ", ".join(map(lambda a: "{} = {}".format(to_toml(a[0]), to_toml(a[1])), value.items())) + "}"

Thank you so much!
I'm just curious : My code emmited build-config = {'LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN' = 'YES'} too, what was the mistake with it?

@albertlarsan68
Copy link
Member

to_toml({"a": "5", "b": "A"}) produced {'a', 'b'=5,'A'}, which is not valid.
Do you understand the difference between the old and the new?

@KittyBorgX
Copy link
Member Author

to_toml({"a": "5", "b": "A"}) produced {'a', 'b'=5,'A'}, which is not valid. Do you understand the difference between the old and the new?

I hadn't given it much thought till now, I replicated a few examples and understood the difference 😅

@albertlarsan68
Copy link
Member

Thanks for the PR!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 2, 2023

📌 Commit a6580ba has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Mar 2, 2023
@compiler-errors
Rollup merge of rust-lang#108644 - KittyBorgX:hashmap-toml, r=albertl…
c897cbe 
…arsan68

Allow setting hashmap toml values in `./configure`

Fixes rust-lang#108621
@compiler-errors compiler-errors mentioned this pull request Mar 2, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 2, 2023
@matthiaskrgr
Rollup merge of rust-lang#108644 - KittyBorgX:hashmap-toml, r=albertl…
5acde60 
…arsan68

Allow setting hashmap toml values in `./configure`

Fixes rust-lang#108621
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 2, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 2, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2023
@bors
Auto merge of rust-lang#108677 - matthiaskrgr:rollup-i91cxuf, r=matth…
7a809ce 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#108022 (Support allocations with non-Box<[u8]> bytes)
 - rust-lang#108367 (Re-apply "switch to the macos-12-xl builder")
 - rust-lang#108557 (Point error span at Some constructor argument when trait resolution fails)
 - rust-lang#108573 (Explain compile-time vs run-time difference in env!() error message)
 - rust-lang#108584 (Put backtick content from rustdoc search errors into a `<code>` elements)
 - rust-lang#108624 (Make `ExprKind` the first field in `thir::Expr`)
 - rust-lang#108644 (Allow setting hashmap toml values in `./configure`)
 - rust-lang#108672 (Feed queries on impl side for RPITITs when using lower_impl_trait_in_trait_to_assoc_ty)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8a21bce into rust-lang:master Mar 3, 2023
@rustbot rustbot added this to the 1.69.0 milestone Mar 3, 2023
@KittyBorgX KittyBorgX deleted the hashmap-toml branch March 7, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertlarsan68 albertlarsan68

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.

./configure doesn't allow setting hashmap toml values
4 participants
@KittyBorgX @rustbot @albertlarsan68 @bors